Skip to content

test(aws-sdk): remove runs for Node.js <18.x #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trivikr wants to merge 6 commits into from
Closed

test(aws-sdk): remove runs for Node.js <18.x #2763

trivikr wants to merge 6 commits into from

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Mar 18, 2025

Which problem is this PR solving?

Short description of the changes

  • Remove runs for Node.js <18.x

@github-actions github-actions bot requested review from blumamir and jj22ee March 18, 2025 23:03
@codecov
Copy link

codecov bot commented Mar 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.51%. Comparing base (37d8ce1) to head (0c47546).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
+ Coverage   90.49%   90.51%   +0.01%     
==========================================
  Files         166      166              
  Lines        8020     8020              
  Branches     1533     1533              
==========================================
+ Hits         7258     7259       +1     
+ Misses        762      761       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr marked this pull request as ready for review March 19, 2025 04:36
@trivikr trivikr requested a review from a team as a code owner March 19, 2025 04:36
@trivikr trivikr requested a review from trentm March 19, 2025 04:36
pichlermarc
pichlermarc reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, please keep the skip-test-if.js script around though. we'll likely need it for other instrumentations soon.

david-luna
david-luna reviewed Mar 19, 2025
View reviewed changes
@trivikr
chore: re-add skip-test-if
0c47546 
This reverts commit 9c21f06.
@trivikr
Copy link
Contributor Author

trivikr commented Mar 20, 2025

This change was done in #2700 (comment)

@trivikr trivikr closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-luna david-luna david-luna left review comments

@pichlermarc pichlermarc pichlermarc left review comments

@blumamir blumamir Awaiting requested review from blumamir

@jj22ee jj22ee Awaiting requested review from jj22ee

@trentm trentm Awaiting requested review from trentm

Assignees

@trivikr trivikr

@blumamir blumamir

@jj22ee jj22ee

Labels

pkg:instrumentation-aws-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trivikr @david-luna @pichlermarc @blumamir @jj22ee